netdev - Re: [PATCH] net: dsa: bcm_sf2: Propagate error value from mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181226.123446.1336493304514420420.davem@davemloft.net>
Date:   Wed, 26 Dec 2018 12:34:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     kjlu@....edu, pakki001@....edu, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: bcm_sf2: Propagate error value from
 mdio_write

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 26 Dec 2018 20:13:15 +0100

> On 26.12.2018 19:21, Kangjie Lu wrote:
>> Both bcm_sf2_sw_indir_rw and mdiobus_write_nested could fail, so let's
>> return their error codes upstream.
>> 
>> Signed-off-by: Kangjie Lu <kjlu@....edu>
>> ---
>>  drivers/net/dsa/bcm_sf2.c | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
>> index 2eb68769562c..236815700fba 100644
>> --- a/drivers/net/dsa/bcm_sf2.c
>> +++ b/drivers/net/dsa/bcm_sf2.c
>> @@ -303,11 +303,10 @@ static int bcm_sf2_sw_mdio_write(struct mii_bus *bus, int addr, int regnum,
>>  	 * send them to our master MDIO bus controller
>>  	 */
>>  	if (addr == BRCM_PSEUDO_PHY_ADDR && priv->indir_phy_mask & BIT(addr))
>> -		bcm_sf2_sw_indir_rw(priv, 0, addr, regnum, val);
>> +		return bcm_sf2_sw_indir_rw(priv, 0, addr, regnum, val);
> This is wrong. Please get familiar with what the function does.
> And test changes before submitting them!

This is getting rediculous.

You are making completely untested changes, resubmitting very quickly
without any care or consideration whatsoever, and wasting a lot of
developer time with your carelessness.

Please stop doing this.