netdev - Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Dec 2018 21:10:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     peng.hao2@....com.cn
Cc:     qiang.zhao@....com, leoyang.li@....com,
        linux-kernel@...r.kernel.org, wen.yang99@....com.cn,
        julia.lawall@...6.fr, netdev@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

From: Peng Hao <peng.hao2@....com.cn>
Date: Wed, 26 Dec 2018 16:26:29 +0800

> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 839fa77..8ce4921f 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -1057,6 +1057,27 @@ static const struct net_device_ops uhdlc_ops = {
>  	.ndo_tx_timeout	= uhdlc_tx_timeout,
>  };
>  
> +static int ucc_get_resource_by_nodename(char *name, struct resource *res)
> +{
 ...
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	return 0;

This assignment to 'res' doesn't do what you think it does.  The caller never
sees the value you compute.