netdev - Re: [PATCH net] net: phy: replace preliminary fix for PHY driver sometimes not binding to the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 29 Dec 2018 12:46:00 +0100
From:   Norbert Jurkeit <norbert.jurkeit@....de>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        David Miller <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Frank Crawford <frank@...wford.emu.id.au>
Subject: Re: [PATCH net] net: phy: replace preliminary fix for PHY driver
 sometimes not binding to the device

Am 29.12.18 um 03:48 schrieb Florian Fainelli:
> Heiner; are you positive that the PHY is not in a power down mode
> (BMCR.PDOWN = 1) at the time the r8169 probe is done? Because if that
> was the case, there is no guarantee (per 802.3 clause 22 spec) that the
> PHY must correctly respond to MDIO operations other than read/write to
> BMCR register and this could explain that problem, as well as the
> general lack of connectivity for these users.

This is a good point, at least in my case. My RTL8111 interface is 
connected to a Wifi router which is normally located out of sight when I 
sit in front of my PC, otherwise I might have noticed this earlier:

When I reboot from kernel 4.18.18 the LAN port status LED turns off at 
the end of the shutdown sequence and remains off with most 4.19.* 
kernels until "rmmod r8169; modprobe r8169" is issued.

When I shutdown&poweroff from kernel 4.18.18 the LED of course also 
turns off but lights up immediately after the PC power button is 
pressed. The network then comes up successfully with all tested 4.19.* 
kernels.

When I reboot from kernel 4.19.* the LED does NOT turn off during 
shutdown (only for about 1s during boot shortly before the login screen 
appears) and the network also comes up successfully with all 4.19.* kernels.

@Heiner: I hope that helps, otherwise please let me know if I should do 
more testing.