netdev - Re: [PATCH net] net: rtnetlink: address is mandatory for rtnl_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJieiUg4PO9WHeJByXz2FkZP51K2drxPLNtTEWFEDoUvnxwQGA@mail.gmail.com>
Date:   Sun, 30 Dec 2018 11:10:33 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev <netdev@...r.kernel.org>, bridge@...ts.linux-foundation.org,
        David Miller <davem@...emloft.net>,
        David Ahern <dsa@...ulusnetworks.com>
Subject: Re: [PATCH net] net: rtnetlink: address is mandatory for rtnl_fdb_get

On Sun, Dec 30, 2018 at 4:33 AM Nikolay Aleksandrov
<nikolay@...ulusnetworks.com> wrote:
>
> We must have an address to lookup otherwise we'll derefence a null
> pointer in the ndo_fdb_get callbacks.
>
> CC: Roopa Prabhu <roopa@...ulusnetworks.com>
> CC: David Ahern <dsa@...ulusnetworks.com>
> Reported-by: syzbot+017b1f61c82a1c3e7efd@...kaller.appspotmail.com
> Fixes: 5b2f94b27622 ("net: rtnetlink: support for fdb get")
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>

Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Thanks Nikolay!.



> ---
>  net/core/rtnetlink.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 48f61885fd6f..5ea1bed08ede 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -4104,6 +4104,11 @@ static int rtnl_fdb_get(struct sk_buff *in_skb, struct nlmsghdr *nlh,
>         if (err < 0)
>                 return err;
>
> +       if (!addr) {
> +               NL_SET_ERR_MSG(extack, "Missing lookup address for fdb get request");
> +               return -EINVAL;
> +       }
> +
>         if (brport_idx) {
>                 dev = __dev_get_by_index(net, brport_idx);
>                 if (!dev) {
> --
> 2.19.2
>