netdev - Re: [PATCH iproute2-next] bridge: fdb: Use 'struct ndmsg' for FDB dumping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b08ec437-01e9-f6d4-44dc-ee520183e55f@gmail.com>
Date:   Sun, 30 Dec 2018 18:03:47 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "stephen@...workplumber.org" <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next] bridge: fdb: Use 'struct ndmsg' for FDB
 dumping

On 12/30/18 10:14 AM, Ido Schimmel wrote:
> Since commit aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on
> socket") iproute2 uses strict checking on kernels that support it. This
> causes FDB dumping to fail [1], as iproute2 uses 'struct ifinfomsg'
> whereas the kernel expects 'struct ndmsg'.
> 
> Note that with this change iproute2 continues to work on old kernels
> that do not support strict checking, but contain the fix introduced in
> kernel commit bd961c9bc664 ("rtnetlink: fix rtnl_fdb_dump() for ndmsg
> header").
> 
> [1]
> # bridge fdb show
> [ 5365.137224] netlink: 4 bytes leftover after parsing attributes in process `bridge'.
> Error: bytes leftover after parsing attributes.
> Dump terminated
> 
> Fixes: aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on socket")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  bridge/fdb.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

applied to iproute2-next. Thanks, Ido.