netdev - Re: [PATCH] mt76: make const array 'data' static, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <453b64e0-220e-69a8-c855-51903707a88b@nbd.name>
Date:   Mon, 31 Dec 2018 15:41:21 +0100
From:   Felix Fietkau <nbd@....name>
To:     Colin King <colin.king@...onical.com>,
        Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mt76: make const array 'data' static, shrinks object size

On 2018-12-30 14:26, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the const array 'data' on the stack but instead
> make it static. Makes the object code smaller by 78 bytes:
> 
> Before:
>    text    data     bss     dec     hex filename
>    5438    1080       0    6518    1976 mediatek/mt76/mt76x2/usb_mcu.o
> 
> After:
>    text    data     bss     dec     hex filename
>    5296    1144       0    6440    1928 mediatek/mt76/mt76x2/usb_mcu.o
> 
> (gcc version 8.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Applied, thanks.

- Felix