netdev - Re: [PATCH iproute2] ip: support for xfrm interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Dec 2018 22:11:22 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Matt Ellison <matt@...oyo.io>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip: support for xfrm interfaces

On Fri, 28 Dec 2018 10:32:11 -0500
Matt Ellison <matt@...oyo.io> wrote:

> Support for new (4.19+) xfrm virtual interfaces.
> 
> Interfaces take a 'if_id' which is an interface id which can be set on
> an xfrm policy as its interface lookup key (XFRMA_IF_ID).
> 
> Signed-off-by: Matt Ellison <matt@...oyo.io>

Wanted to apply this, but it has lots of style issues.
The biggest one is indenting with spaces instead of tabs.
You can use the kernel checkpatch utility to ensure that it is correct.

Other changes needed:
1. For new code just use SPDX style license id, no need to quote GPL
/* SPDX-License-Identifier: GPL-2.0 */

2. Please make help function simpler:

static void xfrm_print_help(struct link_util *lu,
			    int argc, char **argv, FILE *f)
{
	fprintf(f, "Usage: ... %-4s dev PHYS_DEV [ if_id IF-ID ]\n", lu->id);
	fprintf(f, "\nWhere: IF-ID := { 0x0..0xffffffff }\n");
}

The code part looks ok, but you should also update the man page
and add test cases if possible.

Please fix and resubmit.