netdev - Re: [PATCH] configure: Fix to minor error caused by 377a09902a57 ("configure: Minor code cleanup")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Jan 2019 15:38:44 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     firasuke@...il.com
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH] configure: Fix to minor error caused by 377a09902a57
 ("configure: Minor code cleanup")

On 01.01.2019 12:13, firasuke@...il.com wrote:
> From: Firas Khalil Khana <firasuke@...il.com>
> 
> Fixes: 377a09902a57 ("configure: Minor code cleanup")
> 
I think the patch should be annotated iproute2 to make clear
it's not about the kernel. And it's missing a description
which issue was fixed.

> Signed-off-by: Firas Khalil Khana <firasuke@...il.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index b85eb58b..45fcffb6 100755
> --- a/configure
> +++ b/configure
> @@ -115,7 +115,7 @@ EOF
>  check_xt_old_internal_h()
>  {
>      # bail if previous XT checks has already succeeded.
> -    grep -q if grep -q TC_CONFIG_XT $CONFIG && return
> +    grep -q TC_CONFIG_XT $CONFIG && return
>  
>      #check if we need our own internal.h
>      cat >$TMPDIR/ipttest.c <<EOF
>