[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 2 Jan 2019 00:36:08 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Kirill Tkhai <ktkhai@...tuozzo.com>,
Murali Krishna Policharla <murali.policharla@...adcom.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"amritha.nambiar@...el.com" <amritha.nambiar@...el.com>,
"ecree@...arflare.com" <ecree@...arflare.com>,
"alexander.h.duyck@...el.com" <alexander.h.duyck@...el.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: core: Fix to store new mtu setting in netdevice.
> > Is there a .ndo_change_mtu callback, which does not assign a new mtu itself?
> >
> So far all drivers have to do it themselves. But IMO this is more a workaround
> for the core not doing it. It's something the core should do.
> Now we can remove this from drivers.
Hi Heiner
I think somebody first needs to review all the ndo_change_mtu
implementations and check that none do something funny like round to
multiple of 2 or 4 to satisfy DMA restrictions, etc. If there is such
a thing, we cannot easily move this into the core.
Andrew
Powered by blists - more mailing lists