netdev - Re: ixgbe / mdio dependancy error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 02 Jan 2019 15:46:34 -0800
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Steve Douthit <stephend@...icom-usa.com>,
        Dave Jones <davej@...emonkey.org.uk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: ixgbe / mdio dependancy error

On Wed, 2019-01-02 at 15:42 -0800, Florian Fainelli wrote:
> On 1/2/19 3:30 PM, Steve Douthit wrote:
> > > This is because PHYLIB=m which forces MDIO_BUS=m.  If you have
> > > IXGBE=y,
> > > then PHYLIB and MDIO_BUS can't be modules.  Working on a patch to
> > > correct the issue.
> > 
> > There was a review comment to select MDIO_DEVICE instead of PHYLIB.
> > PHYLIB seems correct to me now that I'm looking at this again
> > though.  I
> > came up empty looking for any other drivers that select
> > MDIO_DEVICE.
> > 
> > The objection was that DSA devices wouldn't need the PHYLIB API, so
> > why
> > force it to be built-in.  NET_DSA selects PHYLINK which selects
> > PHYLIB.
> > I think we're ok going back to select PHYLIB if that was the only
> > problem.
> 
> Apologies if this was a slightly misguided recommendation, I have to
> admit, I did not consider a case where ixgbe would not be modular
> while
> everything else it would now depend on is.
> 
> There is a similar pattern with any driver that e.g: has a HWMON
> capability in that you must add something like:
> 
> depends on !FOO=y && DEPS=m or something like that.

Yes, and DCA has that same format, which is what I am working on.  Just
means that all the code added by Steve will need to be wrapped with the
config option.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)