netdev - Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device hot-unplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Jan 2019 09:39:39 +0000
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     Stefano Garzarella <sgarzare@...hat.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH RFC 1/2] vsock/virtio: fix kernel panic after device
 hot-unplug

On Thu, Dec 20, 2018 at 01:15:34PM +0100, Stefano Garzarella wrote:
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index 5d3cce9e8744..9dae54698737 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
> @@ -75,6 +75,9 @@ static u32 virtio_transport_get_local_cid(void)
>  {
>  	struct virtio_vsock *vsock = virtio_vsock_get();
>  
> +	if (!vsock)
> +		return VMADDR_CID_ANY;
> +
>  	return vsock->guest_cid;
>  }

This looks unrelated to the rest of the patch.  Why is it necessary?

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)