netdev - Re: hns3: Compilation of hns3_enet.c is triggered without changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <199310fa-e088-1b36-77b9-da696fea4dec@huawei.com>
Date:   Wed, 2 Jan 2019 10:44:12 +0000
From:   John Garry <john.garry@...wei.com>
To:     Stefan Wahren <stefan.wahren@...e.com>,
        Yisen Zhuang <yisen.zhuang@...wei.com>,
        Salil Mehta <salil.mehta@...wei.com>
CC:     <netdev@...r.kernel.org>, Linuxarm <linuxarm@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: hns3: Compilation of hns3_enet.c is triggered without changes

On 29/12/2018 13:10, Stefan Wahren wrote:
> Hi,
>
> during development i noticed that hns3_enet.c is compiled even without any changes to this file.
>
> I think the reason for this is the usage of VERMAGIC_STRING in this file. So it would be nice if you could somehow replace this define.
>
> Kind regards
> Stefan
>
>

I reported this issue internally some time ago. Apparently it is 
required to reference VERMAGIC_STRING, but I don't know why.

I see that this driver has similar issue:
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/netronome/nfp/nfp_main.c#L34

Another annoying thing I find is the amount of references to UTS_RELEASE 
(which also causes rebuilds), like:
https://elixir.bootlin.com/linux/latest/source/drivers/base/firmware_loader/main.c#L281

Can't we just make a static string for these, to save the rebuilding the 
dependent modules?

Thanks,
John