netdev - Re: [PATCH 4.14 4/4] netfilter: nf_conncount: fix garbage collection confirm race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO9xwp1zw2DBwDRBYMo1ACYcqvZO1MGNHrabZVZ9BwopVEjO7g@mail.gmail.com>
Date:   Wed, 2 Jan 2019 15:07:26 -0200
From:   Mauricio Faria de Oliveira <mfo@...onical.com>
To:     Florian Westphal <fw@...len.de>
Cc:     stable@...r.kernel.org, netdev@...r.kernel.org,
        Alakesh Haloi <alakeshh@...zon.com>,
        Nivedita Singhvi <nivedita.singhvi@...onical.com>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        "David S. Miller" <davem@...emloft.net>,
        Yi-Hung Wei <yihung.wei@...il.com>
Subject: Re: [PATCH 4.14 4/4] netfilter: nf_conncount: fix garbage collection
 confirm race

On Wed, Jan 2, 2019 at 3:06 PM Florian Westphal <fw@...len.de> wrote:
>
> Mauricio Faria de Oliveira <mfo@...onical.com> wrote:
> > +static const struct nf_conntrack_tuple_hash *
> > +find_or_evict(struct net *net, struct xt_connlimit_conn *conn)
> > +{
> > +     const struct nf_conntrack_tuple_hash *found;
> > +     unsigned long a, b;
> > +     int cpu = raw_smp_processor_id();
> > +     __s32 age;
>
> This needs to be 'u32'.  Alternatively, also backport
>
> 4cd273bb91b3001f623 ("netfilter: nf_conncount: don't skip eviction when
> age is negative").

Sure, will pick that up.  Waiting for more comments before sending a v2.


-- 
Mauricio Faria de Oliveira