netdev - Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWvLSVVJcr_R9jhmM3LQsmA=2Nu=D+=WfyMM_aGJqGD_g@mail.gmail.com>
Date:   Thu, 3 Jan 2019 12:44:15 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Bartek Kois <bartek.kois@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: Problem with queuing vlan tagged packets after migration from
 3.16.0 to 4.9.0

On Thu, Jan 3, 2019 at 7:25 AM Bartek Kois <bartek.kois@...il.com> wrote:
>
> Hi
> 1. What exactly caused this change in the kernel?


I don't follow VLAN changes, I guess it must be some change which
inserts the VLAN tag before this ->ndo_start_xmit().


> 2. I don`t understand why adding VLAN tag, which is just 4  additional
> bytes to the passing packet make it impossible to classify.

It is possible, you just have to specify the offset manually, as the
iproute2 can't detect the offset of IP header in this case. So it is just
inconvenient.


> 3. This whole thing makes the QoS under Linux routers hard to configure
> in scenarios with more than one VLAN which is pretty much every slightly
> bigger router nowadays especially if we use IFB and hashing filters. Is
> there any walkaround for that problem?
>

Just move these filters from physical device to the VLAN device instead?


Thanks.