lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 3 Jan 2019 14:28:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Marek Vasut <marex@...x.de>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Nisar Sayed <Nisar.Sayed@...rochip.com>,
        Woojung Huh <Woojung.Huh@...rochip.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 12/19] usbnet: smsc95xx: Replace ad-hoc PHY functions
 with generic ones

On Thu, Jan 03, 2019 at 02:10:33AM +0100, Marek Vasut wrote:
> Replace the ad-hoc reimplementation of genphy_soft_reset() and
> genphy_config_aneg() with the generic functions.

phylib will either call the phy driver specific reset function, or
genphy_soft_reset. The same is also true for configuring
auto-neg. Please just kill this code and leave the PHY driver to do
its job.

	  Andrew

Powered by blists - more mailing lists