netdev - Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afee1791-be69-2cd7-f198-6c84a6d1a4ca@silicom-usa.com>
Date:   Fri, 4 Jan 2019 15:09:32 +0000
From:   Steve Douthit <stephend@...icom-usa.com>
To:     "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Dave Jones <davej@...emonkey.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

On 1/3/19 7:55 PM, Jeff Kirsher wrote:
> I initially tried that, but we get a recursive Kconfig dependency error
> when IPSec is enabled as well, which I noted in the commit message.
I'm not running into the dependency issue you mention in my own testing
of the 'select PHYLIB' patch.  All of the following configurations build
for me with no issues:

			0 1 2 3 4 5
CONFIG_IXGBE		m m m m y y
CONFIG_IXGBE_IPSEC	n y n y n y
CONFIG_MDIO_BUS		m m y y y y
CONFIG_PHYLIB		m m y y y y

I also confirmed that I can't have CONFIG_MDIO_BUS=m and CONFIG_IXGBE=y.
Setting CONFIG_IXGBE=y forces CONFIG_MDIO_BUS=y.

Base config I started with is here: https://pastebin.com/yFsiRRQZ
That's the config 0 from above, the only diff to the other configs was
to set the appropriate symbol to 'y'.

I also tested against the config Dave posted (accepting fixdep defaults)
and that also worked.

What am I missing here?

Can you post the config you were using that had the dependency problem
with CONFIG_IXGBE_IPSEC?