netdev - Re: [PATCH V4] net: phy: tja11xx: Add TJA11xx PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E29570D9-3298-443A-8809-7E5BC4147FCD@gmail.com>
Date:   Fri, 04 Jan 2019 08:24:19 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Marek Vasut <marex@...x.de>, netdev@...r.kernel.org
CC:     Andrew Lunn <andrew@...n.ch>, Guenter Roeck <linux@...ck-us.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH V4] net: phy: tja11xx: Add TJA11xx PHY driver



On January 3, 2019 6:15:47 PM PST, Marek Vasut <marex@...x.de> wrote:
>Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special
>BroadRReach 100BaseT1 PHYs used in automotive.
>
>Signed-off-by: Marek Vasut <marex@...x.de>
>Cc: Andrew Lunn <andrew@...n.ch>
>Cc: Florian Fainelli <f.fainelli@...il.com>
>Cc: Guenter Roeck <linux@...ck-us.net>
>Cc: Heiner Kallweit <hkallweit1@...il.com>
>Cc: Jean Delvare <jdelvare@...e.com>
>Cc: linux-hwmon@...r.kernel.org
>---
>V2: - Use phy_modify(), phy_{set,clear}_bits()
>    - Drop enable argument of tja11xx_enable_link_control()
>    - Use PHY_BASIC_T1_FEATURES and dont modify supported/advertised
>      features in config_init callback
>    - Use genphy_soft_reset() instead of opencoding the reset sequence.
>    - Drop the aneg parts, since the PHY datasheet claims it does not
>      support aneg
>V3: - Replace clr with mask
>    - Add hwmon support
>    - Check commstat in tja11xx_read_status() only if link is up
>    - Use PHY_ID_MATCH_MODEL()
>V4: - Use correct bit in tja11xx_hwmon_read() hwmon_temp_crit_alarm
>    - Use ENOMEM if devm_kstrdup() fails
>    - Check $type in tja11xx_hwmon_read() in addition to $attr
>---

[Snip]

>+	ret = tja11xx_enable_reg_write(phydev);
>+	if (ret)
>+		return ret;
>+
>+	phydev->irq = PHY_POLL;

The PHY driver should not be imposing that, leave it up to the platform configuration to set that.

>+	phydev->autoneg = AUTONEG_DISABLE;
>+	phydev->speed = SPEED_100;
>+	phydev->duplex = DUPLEX_FULL;
>+	phydev->pause = 0;
>+	phydev->asym_pause = 0;

Are any of those necessary if you set basic T1 features?

Everything else looks good to me. Thanks!
-- 
Florian