netdev - Re: [PATCH v2] netlink: fixup regression in RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 04 Jan 2019 12:48:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     baloo@...di.net
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH v2] netlink: fixup regression in RTM_GETADDR

From: baloo@...di.net
Date: Mon, 31 Dec 2018 02:10:58 +0000

> From: Arthur Gautier <baloo@...di.net>
> 
> This commit fixes a regression in AF_INET/RTM_GETADDR and
> AF_INET6/RTM_GETADDR.
> 
> Before this commit, the kernel would stop dumping addresses once the first
> skb was full and end the stream with NLMSG_DONE(-EMSGSIZE). The error
> shouldn't be sent back to netlink_dump so the callback is kept alive. The
> userspace is expected to call back with a new empty skb.
> 
> Changes from V1:
>  - The error is not handled in netlink_dump anymore but rather in
>    inet_dump_ifaddr and inet6_dump_addr directly as suggested by
>    David Ahern.
> 
> Fixes: d7e38611b81e ("net/ipv4: Put target net when address dump fails due to bad attributes")
> Fixes: 242afaa6968c ("net/ipv6: Put target net when address dump fails due to bad attributes")
> 
> Cc: David Ahern <dsahern@...il.com>
> Cc: "David S . Miller" <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Arthur Gautier <baloo@...di.net>

Applied and queued up for -stable, thanks!