netdev - Re: [PATCH net-next] Optimize sk_msg_clone() by data merge to end dst sg entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190104.125449.755695635901352642.davem@davemloft.net>
Date:   Fri, 04 Jan 2019 12:54:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vakul.garg@....com
Cc:     netdev@...r.kernel.org, john.fastabend@...il.com,
        daniel@...earbox.net, davejwatson@...com
Subject: Re: [PATCH net-next] Optimize sk_msg_clone() by data merge to end
 dst sg entry

From: Vakul Garg <vakul.garg@....com>
Date: Wed, 2 Jan 2019 09:36:59 +0000

> Function sk_msg_clone has been modified to merge the data from source sg
> entry to destination sg entry if the cloned data resides in same page
> and is contiguous to the end entry of destination sk_msg. This improves
> kernel tls throughput to the tune of 10%.
> 
> When the user space tls application calls sendmsg() with MSG_MORE, it leads
> to calling sk_msg_clone() with new data being cloned placed continuous to
> previously cloned data. Without this optimization, a new SG entry in
> the destination sk_msg i.e. rec->msg_plaintext in tls_clone_plaintext_msg()
> gets used. This leads to exhaustion of sg entries in rec->msg_plaintext
> even before a full 16K of allowable record data is accumulated. Hence we
> lose oppurtunity to encrypt and send a full 16K record.
> 
> With this patch, the kernel tls can accumulate full 16K of record data
> irrespective of the size of data passed in sendmsg() with MSG_MORE.
> 
> Signed-off-by: Vakul Garg <vakul.garg@....com>

Please resubmit when net-next opens back up.

Thank you.