netdev - Re: [net v3] ixgbe: fix Kconfig when driver is not a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190104.133943.1670966834258094158.davem@davemloft.net>
Date:   Fri, 04 Jan 2019 13:39:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
        davej@...emonkey.org.uk, stephend@...icom-usa.com,
        f.fainelli@...il.com
Subject: Re: [net v3] ixgbe: fix Kconfig when driver is not a module

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri,  4 Jan 2019 10:48:02 -0800

> The new ability added to the driver to use mii_bus to handle MII related
> ioctls is causing compile issues when the driver is compiled into the
> kernel (i.e. not a module).
> 
> The problem was in selecting MDIO_DEVICE instead of the preferred PHYLIB
> Kconfig option.  The reason being that MDIO_DEVICE had a dependency on
> PHYLIB and would be compiled as a module when PHYLIB was a module, no
> matter whether ixgbe was compiled into the kernel.
> 
> CC: Dave Jones <davej@...emonkey.org.uk>
> CC: Steve Douthit <stephend@...icom-usa.com>
> CC: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> v2: fixed up the Kconfig help section to include the clause 22/45
>   address information and also changed the IXGBE_MDIO config option to be
>   dependent upon PHYLIB versus MDIO_BUS since that appears to be the
>   common usage
> 
> v3: Steve Douthit found a much simpler solution of changing the
>   dependency from MDIO_DEVICE to PHYLIB, which is consistent with other
>   Ethernet drivers

Jeff, would you like me to apply this directly?

Thanks.