netdev - Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c0cf12c-67e9-a2fd-d65e-6bca6803fe65@denx.de>
Date:   Fri, 4 Jan 2019 06:40:46 +0100
From:   Marek Vasut <marex@...x.de>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver

On 1/4/19 3:57 AM, Florian Fainelli wrote:
> 
> 
> On 1/3/2019 6:53 PM, Marek Vasut wrote:
>> On 1/4/19 3:19 AM, Marek Vasut wrote:
>>
>> [...]
>>
>> On a separate note, I was pondering about the master/slave mode of the
>> TJA11xx PHY. Right now, the driver only operates in Automatic mode,
>> however the PHY can be force-configured as either master or slave.
>> Would using .set_tunable with a new tunable type be a good way to expose
>> this to userspace ? The ethtool can then configure the PHY mode.
> 
> Using an ethtool u8 tunable would be fine, with something like:
> 
> 0 -> automatic
> 1 -> force master
> 2 -> force slave

Fine, however I'll send it as a separate patch later.
How does this name/macro sound for the tunable ?

[ETHTOOL_PHY_BRR_MODE]  = "phy-broadrreach-mode",

-- 
Best regards,
Marek Vasut