netdev - Re: [PATCH bpf] selftests/bpf: fix incorrect users of create_and_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190105043438.4nr7hxc4gbqayp5v@ast-mbp.dhcp.thefacebook.com>
Date:   Fri, 4 Jan 2019 20:34:40 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, ast@...nel.org,
        daniel@...earbox.net
Subject: Re: [PATCH bpf] selftests/bpf: fix incorrect users of
 create_and_get_cgroup

On Thu, Jan 03, 2019 at 10:57:17AM -0800, Stanislav Fomichev wrote:
> create_and_get_cgroup returns 0 on error, fix the users that assume
> negative value in case of an error.
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> ---
>  tools/testing/selftests/bpf/get_cgroup_id_user.c | 2 +-
>  tools/testing/selftests/bpf/test_sockmap.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/get_cgroup_id_user.c b/tools/testing/selftests/bpf/get_cgroup_id_user.c
> index e8da7b39158d..dfaa9b353ac3 100644
> --- a/tools/testing/selftests/bpf/get_cgroup_id_user.c
> +++ b/tools/testing/selftests/bpf/get_cgroup_id_user.c
> @@ -64,7 +64,7 @@ int main(int argc, char **argv)
>  		return 1;
>  
>  	cgroup_fd = create_and_get_cgroup(TEST_CGROUP);
> -	if (CHECK(cgroup_fd < 0, "create_and_get_cgroup", "err %d errno %d\n",
> +	if (CHECK(!cgroup_fd, "create_and_get_cgroup", "err %d errno %d\n",

fd can be zero.
Hence I prefer to fix it the other way to avoid this corner case.
Pls fix create_and_get_cgroup() to return -1 in case of error.
The diff will be much bigger, but overall it's imo cleaner.
Also pls add Fixes tag.

Thanks