netdev - Re: [PATCH] tipc: fix memory leak in tipc_nl_compat_publ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fb4bb46-5f2e-ae8d-df16-500d7a39c118@windriver.com>
Date:   Sun, 6 Jan 2019 13:41:22 +0800
From:   Ying Xue <ying.xue@...driver.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kangjie Lu <kjlu@....edu>, Jon Maloy <jon.maloy@...csson.com>,
        "David S. Miller" <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tipc: fix memory leak in tipc_nl_compat_publ_dump

On 1/6/19 12:52 AM, Gustavo A. R. Silva wrote:
> There is a memory leak in case genlmsg_put fails.
> 
> Fix this by freeing *args* before return.
> 
> Addresses-Coverity-ID: 1476406 ("Resource leak")
> Fixes: 46273cf7e009 ("tipc: fix a missing check of genlmsg_put")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Acked-by: Ying Xue <ying.xue@...driver.com>

> ---
>  net/tipc/netlink_compat.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
> index 40f5cae623a7..77e4b2418f30 100644
> --- a/net/tipc/netlink_compat.c
> +++ b/net/tipc/netlink_compat.c
> @@ -904,8 +904,10 @@ static int tipc_nl_compat_publ_dump(struct tipc_nl_compat_msg *msg, u32 sock)
>  
>  	hdr = genlmsg_put(args, 0, 0, &tipc_genl_family, NLM_F_MULTI,
>  			  TIPC_NL_PUBL_GET);
> -	if (!hdr)
> +	if (!hdr) {
> +		kfree_skb(args);
>  		return -EMSGSIZE;
> +	}
>  
>  	nest = nla_nest_start(args, TIPC_NLA_SOCK);
>  	if (!nest) {
>