netdev - [PATCH lora-next 09/11] net: lora: sx130x: Mark AGCSTS register as volatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun,  6 Jan 2019 09:37:52 +0100
From:   Andreas Färber <afaerber@...e.de>
To:     linux-lpwan@...ts.infradead.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andreas Färber <afaerber@...e.de>,
        Ben Whitten <ben.whitten@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: [PATCH lora-next 09/11] net: lora: sx130x: Mark AGCSTS register as volatile

AGC status register reads should not be cached.

Sort the volatile registers by number while at it.

Cc: Ben Whitten <ben.whitten@...il.com>
Signed-off-by: Andreas Färber <afaerber@...e.de>
---
 drivers/net/lora/sx130x.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/lora/sx130x.c b/drivers/net/lora/sx130x.c
index 0a79548a7480..8bdd343a273f 100644
--- a/drivers/net/lora/sx130x.c
+++ b/drivers/net/lora/sx130x.c
@@ -123,11 +123,13 @@ static const struct regmap_range_cfg sx130x_regmap_ranges[] = {
 static bool sx130x_volatile_reg(struct device *dev, unsigned int reg)
 {
 	switch (reg) {
-	case SX1301_DBG_AGC_MCU_RAM_DATA:
-	case SX1301_DBG_ARB_MCU_RAM_DATA:
 	case SX1301_MPD:
+	case SX1301_AGCSTS:
+
 	case SX1301_RADIO_A_SPI_DATA_RB:
 	case SX1301_RADIO_B_SPI_DATA_RB:
+	case SX1301_DBG_ARB_MCU_RAM_DATA:
+	case SX1301_DBG_AGC_MCU_RAM_DATA:
 		return true;
 	default:
 		return false;
-- 
2.16.4