netdev - Re: [PATCH net v3 1/4] umh: add exit routine for UMH process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTVAWYBYhEwaWT0qZfo2=6p-OBqVvGqMHKj2wtkv8am-GA@mail.gmail.com>
Date:   Tue, 8 Jan 2019 02:18:38 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org,
        Daniel Borkmann <daniel@...earbox.net>, ast@...nel.org,
        mcgrof@...nel.org
Subject: Re: [PATCH net v3 1/4] umh: add exit routine for UMH process

On Tue, 8 Jan 2019 at 00:25, David Miller <davem@...emloft.net> wrote:
>
> From: Taehee Yoo <ap420073@...il.com>
> Date: Mon,  7 Jan 2019 21:10:14 +0900
>
> > @@ -679,6 +688,29 @@ static int proc_cap_handler(struct ctl_table *table, int write,
> >       return 0;
> >  }
> >
> > +void exit_umh(struct task_struct *tsk)
> > +{
> > +     struct umh_info *info;
> > +     pid_t pid = tsk->pid;
> > +
> > +     if (!(tsk->flags & PF_UMH))
> > +             return;
>
> Let's really make this low cost.
>
> In linux/sched.h or similar:
>
> void __exit_umh(struct task_struct *tsk);
>
> static inline void exit_umh(struct task_struct *tsk)
> {
>         if (unlikely(tsk->flags & PF_UMH))
>                 __exit_umh(tsk);
> }
>
> Thank you.

Thanks a lot for the review!

I will send a v4 patch.