netdev - Re: [PATCH] phy: ti: Fix compilation failures without REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190107181739.GA27929@mellanox.com>
Date:   Mon, 7 Jan 2019 18:17:46 +0000
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Grygorii Strashko <grygorii.strashko@...com>,
        Kishon Vijay Abraham I <kishon@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] phy: ti: Fix compilation failures without REGMAP

On Mon, Jan 07, 2019 at 07:13:00PM +0100, Andrew Lunn wrote:
> On Mon, Jan 07, 2019 at 05:48:00PM +0000, Jason Gunthorpe wrote:
> > This driver requires regmap or the compile fails:
> > 
> > drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
> >   const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];
> > 
> > Add it to kconfig.
> 
> Hi Jason
> 
> It looks like more of the TI drivers need REGMAP, but don't select it.
> I assume you are using COMPILE_TEST, since TI_CPSW selects REGMAP?

Yes, this causes COMPILE_TEST kernels to fail.

Jason