lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Jan 2019 10:53:52 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Pavel Machek <pavel@....cz>, Vokáč Michal <Michal.Vokac@...ft.com>, trivial@...nel.org Cc: "andrew@...n.ch" <andrew@...n.ch>, "vivien.didelot@...oirfairelinux.com" <vivien.didelot@...oirfairelinux.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "buytenh@...vell.com" <buytenh@...vell.com>, "buytenh@...tstofly.org" <buytenh@...tstofly.org>, "nico@...vell.com" <nico@...vell.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "mark.rutland@....com" <mark.rutland@....com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, kernel list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] dsa device tree bindings: fix typo and wrong example On 1/7/19 10:49 AM, Pavel Machek wrote: > On Thu 2018-12-06 13:28:56, Vokáč Michal wrote: >> On 6.12.2018 14:05, Pavel Machek wrote: >>> >>> Fix typo and fix compatible value that is not actually permitted by the >>> description in the example. >> >> Ahoj Pavle, I think the subject should be more like: >> >> "dt-bindings: net: dsa: ..." > > Ahoj! > > Well, retrying with different subject only makes sense if someone is > interested. Rob, Andrew -- can you take the patch? > > Do you want me to edit the subject or can you just edit the subject > while applying? The next steps would likely be for you to resubmit this patch with a re-subjected patch and I am fairly sure David can pick it up right away since this is not a functional change. > > Thanks, > Pavel > >> BR, Michal >> >>> >>> Signed-off-by: Pavel Machek <pavel@....cz> >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt >>> index feb007af13cb..abf1be036ac5 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt >>> +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt >>> @@ -41,7 +41,7 @@ Optional properties: >>> - mdio : Container of PHY and devices on the switches MDIO >>> bus. >>> - mdio? : Container of PHYs and devices on the external MDIO >>> - bus. The node must contains a compatible string of >>> + bus. The node must contain a compatible string of >>> "marvell,mv88e6xxx-mdio-external" >>> >>> Example: >>> @@ -80,7 +80,7 @@ Example: >>> #interrupt-cells = <2>; >>> >>> switch0: switch@0 { >>> - compatible = "marvell,mv88e6390"; >>> + compatible = "marvell,mv88e6190"; >>> reg = <0>; >>> reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>; >>> >>> >>> > -- Florian
Powered by blists - more mailing lists