netdev - Re: [RFC iproute2] xfrm: add option to hide keys in state output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANrj0bbTWY5Zm5UiSSykSSkzG55ajkV6wfj2gGKGzaeGht9N9A@mail.gmail.com>
Date:   Mon, 7 Jan 2019 12:37:41 -0800
From:   Benedict Wong <benedictwong@...gle.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, Nathan Harold <nharold@...gle.com>,
        Lorenzo Colitti <lorenzo@...gle.com>,
        Maciej Żenczykowski <maze@...gle.com>
Subject: Re: [RFC iproute2] xfrm: add option to hide keys in state output

Noted. Should I wait until xfrm is converted to JSON output formatting?

Or if there are no structural and stylistic issues, should I re-send
this as a patch?

On Fri, Jan 4, 2019 at 4:21 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Fri,  4 Jan 2019 15:19:10 -0800
> Benedict Wong <benedictwong@...gle.com> wrote:
>
> > ip xfrm state show currently dumps keys unconditionally. This limits its
> > use in logging, as security information can be leaked.
> >
> > This patch adds a nokeys option to ip xfrm ( state show | monitor ), which
> > prevents the printing of keys. This allows ip xfrm state show to be used
> > in logging without exposing keys.
> >
> > Signed-off-by: Benedict Wong <benedictwong@...gle.com>
> > ---
> >  ip/ipxfrm.c        | 45 +++++++++++++++++++++++++--------------------
> >  ip/xfrm.h          |  5 +++--
> >  ip/xfrm_monitor.c  |  7 +++++--
> >  ip/xfrm_state.c    | 27 ++++++++++++++++++++++-----
> >  man/man8/ip-xfrm.8 | 15 ++++++++++++++-
> >  5 files changed, 69 insertions(+), 30 deletions(-)
> >
> > diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c
> > index 2dea4e37..1334ca9f 100644
> > --- a/ip/ipxfrm.c
> > +++ b/ip/ipxfrm.c
> > @@ -497,7 +497,8 @@ void xfrm_selector_print(struct xfrm_selector *sel, __u16 family,
> >  }
> >
> >  static void __xfrm_algo_print(struct xfrm_algo *algo, int type, int len,
> > -                           FILE *fp, const char *prefix, int newline)
> > +                           FILE *fp, const char *prefix, int newline,
> > +                           bool nokeys)
> >  {
> >       int keylen;
> >       int i;
> > @@ -521,7 +522,9 @@ static void __xfrm_algo_print(struct xfrm_algo *algo, int type, int len,
> >               goto fin;
> >       }
> >
> > -     if (keylen > 0) {
> > +     if (nokeys)
> > +             fprintf(fp, "<<Keys hidden>>")
>
>
> This reminds me, xfrm never got converted to use JSON output formatting.