netdev - Re: [PATCH bpf v2] selftests/bpf: fix incorrect users of create_and_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190107211922.2qxssfqydip3tdcy@ast-mbp>
Date:   Mon, 7 Jan 2019 13:19:23 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     netdev@...r.kernel.org, ys114321@...il.com, davem@...emloft.net,
        ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH bpf v2] selftests/bpf: fix incorrect users of
 create_and_get_cgroup

On Mon, Jan 07, 2019 at 09:46:46AM -0800, Stanislav Fomichev wrote:
> We have some tests that assume create_and_get_cgroup returns -1 on error
> which is incorrect (it returns 0 on error). Since fd might be zero in
> general case, change create_and_get_cgroup to return -1 on error
> and fix the users that assume 0 on error.
> 
> Fixes: f269099a7e7a ("tools/bpf: add a selftest for bpf_get_current_cgroup_id() helper")
> Fixes: 7d2c6cfc5411 ("bpf: use --cgroup in test_suite if supplied")
> 
> v2:
> - instead of fixing the uses that assume -1 on error, convert the users
>   that assume 0 on error (fd might be zero in general case)
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

Applied, Thanks