netdev - Re: [PATCH iproute2-next] Improve batch times by caching link lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190107133155.6da96d55@hermes.lan>
Date:   Mon, 7 Jan 2019 13:31:55 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2-next] Improve batch times by caching link
 lookups

On Mon,  7 Jan 2019 12:41:30 -0800
David Ahern <dsahern@...nel.org> wrote:

> From: David Ahern <dsahern@...il.com>
> 
> ip route uses ll_name_to_index to convert the user given device name to an
> index. At the moment ll_name_to_index uses if_nametoindex which is ioctl
> based and does not cache the result. When using a batch file this means
> the same device lookups can be done repeatedly adding unnecessary overhead
> (socket + ioctl call for each device lookup).
> 
> Add a new function, ll_link_get, to send a netlink based RTM_GETLINK. If
> successful, cache the result in idx_head and name_head so future lookups
> can re-use the entry.
> 
> With this change the time to install routes via a batch file is reduced
> from 30.7 seconds to 17.6 seconds (720,022 routes with 2 ecmp nexthops
> where the nexthop device is given).
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

What if a ip command in the batch does a rename?