netdev - Re: [PATCH net] tipc: fix uninit-value in tipc_nl_compat_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190107.053854.859872152037681322.davem@davemloft.net>
Date:   Mon, 07 Jan 2019 05:38:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ying.xue@...driver.com
Cc:     netdev@...r.kernel.org, jon.maloy@...csson.com,
        tipc-discussion@...ts.sourceforge.net,
        syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH net] tipc: fix uninit-value in tipc_nl_compat_link_set

From: Ying Xue <ying.xue@...driver.com>
Date: Mon, 7 Jan 2019 19:29:52 +0800

> This is because lc->name string is not validated before it's used.

It looks like we have several situations like this, not just this one.

For example, tipc_nl_compat_bearer_{enable,disable}() with b->name.

Next, tipc_nl_compat_media_set() and tipc_nl_compat_bearer_set().

On input, tipc_nl_compat_link_stat_dump() blindly does a strcmp()
on one of these strings.

In fact, this entire file is full of errors of this sort.

Can you please address all of them, perhaps using a helper of
some kind to consolidate the logic?

Thank you.