netdev - Re: [PATCH v3 1/4] rtl8723ae: Take the FW LPS mode handling out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 08 Jan 2019 19:27:59 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Bernd Edlinger <bernd.edlinger@...mail.de>
Cc:     Ping-Ke Shih <pkshih@...ltek.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v3 1/4] rtl8723ae: Take the FW LPS mode handling out

Bernd Edlinger <bernd.edlinger@...mail.de> writes:

> This appears to trigger a firmware bug and causes severe
> problems with rtl8723ae PCI devices.
>
> When the power save mode is activated for longer periods
> of time the firmware stops to receive any packets.
>
> This problem was exposed by commit 873ffe154ae0 ("rtlwifi:
> Fix logic error in enter/exit power-save mode").
>
> Previously the power save mode was only active rarely and
> only for a short time so that the problem was not noticeable.
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@...mail.de>
> ---
> v2: Adjust the defaults of swlps and fwlps module
> parameters to match the firmware capabilities instead of removing
> the whole code, so it can be easily re-activated once a firmware
> update is available.
>
> v3: Make the title fit in one line.

hotmail.de made me suspicious and indeed my Spidey sense was right:

Applying: rtl8723ae: Take the FW LPS mode handling out
Using index info to reconstruct a base tree...
.git/rebase-apply/patch:22: trailing whitespace.
        .swctrl_lps = true,
.git/rebase-apply/patch:23: trailing whitespace.
        .fwctrl_lps = false,
.git/rebase-apply/patch:33: trailing whitespace.
MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 1)\n");
.git/rebase-apply/patch:34: trailing whitespace.
MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 0)\n");
error: patch failed: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c:266
error: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 rtl8723ae: Take the FW LPS mode handling out

Did you use Outlook to send this patch or what? Anyway, it's strongly
suggested to use git to submit the patches (and not use Outlook servers
either as they are notorious in breaking our patches):

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues

-- 
Kalle Valo