netdev - Re: [PATCH iproute2-next 3/3] Improve batch times by caching link lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3a655d3-f1a4-4cf0-07b4-57adcff0c6d5@gmail.com>
Date:   Mon, 7 Jan 2019 17:28:43 -0700
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next 3/3] Improve batch times by caching link
 lookups

On 1/7/19 5:05 PM, Stephen Hemminger wrote:
> On Mon,  7 Jan 2019 14:55:52 -0800
> David Ahern <dsahern@...nel.org> wrote:
> 
>> +	idx = ll_link_get(name);
>> +	if (idx == 0)
>> +		idx = if_nametoindex(name);
> 
> What is advantage of using netlink, other than not having to open
> a socket.
> 

As mentioned in my response to Eric, use of netlink is to keep the cache
entries in sync. The existing cache is populated by netlink messages;
this function should follow suit. if_nametoindex does not allow setting
the flags or type fields.