netdev - Re: [PATCH net] net: phy: fix too strict check in phy_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154706941540.18698.2723147609742180922@skylake-alporthouse-com>
Date:   Wed, 09 Jan 2019 21:30:15 +0000
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: fix too strict check in phy_start_aneg

Quoting Heiner Kallweit (2019-01-09 19:34:56)
> When adding checks to detect wrong usage of the phylib API we added
> a check to phy_start_aneg() which is too strict. If the phylib
> state machine is in state PHY_HALTED we should allow reconfiguring
> and restarting aneg, and just don't touch the state.
> 
> Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking")
> Reported-by: Chris Wilson <chris@...is-wilson.co.uk>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Courtesy of intel-gfx's CI farm,
Tested-by: Chris Wilson <chris@...is-wilson.co.uk>

Thanks for the fix,
-Chris