netdev - Re: [PATCH bpf] bpf: correctly set initial window on active Fast Open sender

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190109232114.aczjw74y6vqnbgqf@ast-mbp>
Date:   Wed, 9 Jan 2019 15:21:15 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yuchung Cheng <ycheng@...gle.com>
Cc:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        brakmo@...com, ncardwell@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH bpf] bpf: correctly set initial window on active Fast
 Open sender

On Tue, Jan 08, 2019 at 06:12:24PM -0800, Yuchung Cheng wrote:
> The existing BPF TCP initial congestion window (TCP_BPF_IW) does not
> to work on (active) Fast Open sender. This is because it changes the
> (initial) window only if data_segs_out is zero -- but data_segs_out
> is also incremented on SYN-data.  This patch fixes the issue by
> proerly accounting for SYN-data additionally.
> 
> Fixes: fc7478103c84 ("bpf: Adds support for setting initial cwnd")
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Reviewed-by: Neal Cardwell <ncardwell@...gle.com>

Applied, Thanks