netdev - Re: [PATCH v2 4/5] net: phy: at803x: Disable phy delay for RGMII mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190109043550.GU13372@vkoul-mobl.Dlink>
Date:   Wed, 9 Jan 2019 10:05:50 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     David S Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Niklas Cassel <niklas.cassel@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v2 4/5] net: phy: at803x: Disable phy delay for RGMII mode

Hi Florian,

Thanks for a quick review,

On 08-01-19, 09:59, Florian Fainelli wrote:
> On 1/8/19 8:29 AM, Vinod Koul wrote:

> > +	if (phydev->interface == PHY_INTERFACE_MODE_RGMII) {
> > +		ret = at803x_disable_rx_delay(phydev);
> > +		if (ret < 0)
> > +			return ret;
> > +		ret = at803x_disable_tx_delay(phydev);
> > +		if (ret < 0)
> > +			return ret;
> > +	}
> 
> This looks right in that PHY_INTERFACE_MODE_RGMII from the perspective
> of the PHY means no TX/RX delays, but you would also have to take care
> of PHY_INTERFACE_MODE_RGMII_TXID and disable the RX delay in that case,
> and PHY_INTERFACE_MODE_RGMII_RXID and disabled the TX delay in that case.

Okay and I guess same about the PHY_INTERFACE_MODE_RGMII_ID. Right now
driver enables delay for PHY_INTERFACE_MODE_RGMII_ID and
PHY_INTERFACE_MODE_RGMII_TXID, PHY_INTERFACE_MODE_RGMII_RXID so I would
remove that as well..

Thanks
-- 
~Vinod