netdev - Re: [PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2353d9ae-0def-9a02-e6d0-25351e283128@lwfinger.net>
Date:   Tue, 8 Jan 2019 18:45:21 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Bernd Edlinger <bernd.edlinger@...mail.de>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae

On 1/8/19 4:49 PM, Bernd Edlinger wrote:
> Currently the rtl8723ae driver is broken (since v4.7).
> 
> Connection to AP is lost very often, especially when
> the signal level is not very good.
> 
> The main issue is the power save mode is basically
> not working, and seems to trigger a firmware bug.
> So I had to take out the FW LPS mode handling.
> 
> While debugging the driver I found a couple related issues,
> for instance that the signal level in dm.undec_sm_pwdb
> is no longer accurate (may be even much too high) when no more
> packets are received, and it increases the likelihood to receive
> something if the input gain is set to maximum.
> 
> The patch was tested with the rtl8723ae PCI card in my laptop
> against a FRITZ!Box 7590 AP -- the WiFi connection works now
> very reliable for me.
> 
> ChangeLog:
> 
> v2: Adjusts the defaults of swlps and fwlps module
> parameters to match the firmware capabilities instead of removing
> the whole code, so it can be easily re-activated once a firmware
> update is available.
> 
> v3: Make the title of each patch fit in one line.
> 
> v4: Try to fix the line endings the message body.
>      Which is an exchange server issue.
>      The patch does not change at all.
> 
> Bernd Edlinger (4):
>    rtl8723ae: Take the FW LPS mode handling out
>    rtl8723ae: Dont use old data for input gain control
>    rtl8723ae: Re-introduce the adaptive rate control
>    rtlwifi: Don't clear num_rx_inperiod too early
> 
>   drivers/net/wireless/realtek/rtlwifi/base.c        |  4 +-
>   drivers/net/wireless/realtek/rtlwifi/core.c        |  2 +
>   .../net/wireless/realtek/rtlwifi/rtl8723ae/dm.c    | 95 +++++++++++++++++++++-
>   .../net/wireless/realtek/rtlwifi/rtl8723ae/sw.c    |  8 +-
>   4 files changed, 101 insertions(+), 8 deletions(-)

This version applied OK.

Larry