netdev - Re: [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVcw3+Crg_1vR4sPfG2v+arQVMY2yzBjp7yw296xCaN6Q@mail.gmail.com>
Date:   Tue, 8 Jan 2019 17:38:55 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Toke Høiland-Jørgensen <toke@...e.dk>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Cake List <cake@...ts.bufferbloat.net>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen <toke@...e.dk> wrote:
> @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct Qdisc *sch,
>         if (cl->qdisc->q.qlen != 1) {
>                 if (unlikely(skb == cl->qdisc->ops->peek(cl->qdisc)) &&


Isn't this comparison problematic too? While you are on it...