netdev - MSG_ZEROCOPY doesn't work on half-open TCP sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJPywTKGT8Giuegpm7B4rKp+Qjmz4mCDcZoCwyY63=3s4tqZyQ@mail.gmail.com>
Date:   Wed, 9 Jan 2019 13:01:13 +0100
From:   Marek Majkowski <marek@...udflare.com>
To:     Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org
Subject: MSG_ZEROCOPY doesn't work on half-open TCP sockets

Hi,

Current implementation of MSG_ZEROCOPY for TCP requires the socket to
be ESTABLISHED:
https://elixir.bootlin.com/linux/v5.0-rc1/source/net/ipv4/tcp.c#L1188

if (sk->sk_state != TCP_ESTABLISHED) {
    err = -EINVAL;
    goto out_err;
}

In TCP it's totally fine to have half-open sockets, for example:

shutdown(5, SHUT_RD)

Moves the socket from ESTABLISHED to CLOSE_WAIT. In such TCP state
it's possible to continue sending data. This is not supported by
MSG_ZEROCOPY, which will fail with EINVAL in such case. I think it's a
bug.

Marek