netdev - Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190109160538.GA7273@amd>
Date:   Wed, 9 Jan 2019 17:05:38 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Tristram.Ha@...rochip.com
Cc:     marex@...x.de, pavel@...x.de, jiri@...nulli.us, andrew@...n.ch,
        sergio.paracuellos@...il.com, f.fainelli@...il.com,
        dan.carpenter@...cle.com, vivien.didelot@...oirfairelinux.com,
        UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

On Wed 2018-12-19 22:50:16, Tristram.Ha@...rochip.com wrote:
> > >>>> This header file makes no sense. Please move the functions into .c
> > >>>
> > >>> No, that would make code bigger & slower.
> > >>>
> > >>> It makes sense to me. But I'd add "inline" keyword to make the goal
> > >>> explicit.
> > >>
> > >> 1) It makes no sense to have header files for things like this. The
> > >>    functions are only used within the single .c file.
> > >>
> > >> 2) You cannot inline them, as they are used as ops.
> > >
> > > Ok, sorry for the noise.
> > 
> > If you were to use regmap, this whole boilerplate would go away ...
> 
> Sometimes I am confused about this review process.
> 
> The new code is same as previous code submitted.  The old code was accepted,
> but then there are objections to the new code.

Sometimes you just need to reject review comment...

It took extremely long to merge this driver; that does not help,
either.

Good luck,
								Pavel

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)