netdev - Re: [PATCH RESEND] nft_flow_offload: Fix the peer route get from wrong daddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190109190637.rhqpp2edpikv3vng@salvia>
Date:   Wed, 9 Jan 2019 20:06:37 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     wenxu@...oud.cn
Cc:     netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND] nft_flow_offload: Fix the peer route get from
 wrong daddr

On Wed, Jan 09, 2019 at 08:03:58PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Jan 09, 2019 at 10:40:11AM +0800, wenxu@...oud.cn wrote:
> > From: wenxu <wenxu@...oud.cn>
> > 
> > For nat example:
> > client 1.1.1.7 ---> 2.2.2.7 which dnat to 10.0.0.7 server
> > 
> > When syn_rcv pkt from server it get the peer(client->server) route
> > through daddr = ct->tuplehash[!dir].tuple.dst.u3.ip, the value 2.2.2.7
> > is not correct in this situation. it should be 10.0.0.7
> > ct->tuplehash[dir].tuple.src.u3.ip
> 
> Patch is correct, applied, thanks.

BTW, let me rewrite patch title to:

        netfilter: nft_flow_offload: Fix reverse route lookup

I'll also slightly revisit the patch description before applying.

Thanks.