netdev - Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190110212446.GN5540@atomide.com>
Date:   Thu, 10 Jan 2019 13:24:46 -0800
From:   Tony Lindgren <tony@...mide.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Sekhar Nori <nsekhar@...com>
Subject: Re: [PATCH net] net: phy: micrel: set soft_reset callback to
 genphy_soft_reset for KSZ9031

* Heiner Kallweit <hkallweit1@...il.com> [190110 19:22]:
> So far genphy_soft_reset was used automatically if the PHY driver
> didn't implement the soft_reset callback. This changed with the
> mentioned commit and broke KSZ9031. To fix this configure the
> KSZ9031 PHY driver to use genphy_soft_reset.
> 
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Reported-by: Tony Lindgren <tony@...mide.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Thanks this fixes the regression for me:

Tested-by: Tony Lindgren <tony@...mide.com>

> ---
>  drivers/net/phy/micrel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index c33384710..7828d17f0 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = {
>  	.driver_data	= &ksz9021_type,
>  	.probe		= kszphy_probe,
>  	.config_init	= ksz9031_config_init,
> +	.soft_reset	= genphy_soft_reset,
>  	.read_status	= ksz9031_read_status,
>  	.ack_interrupt	= kszphy_ack_interrupt,
>  	.config_intr	= kszphy_config_intr,
> -- 
> 2.20.1
>