lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190110095914.GB19025@stefanha-x1.localdomain>
Date:   Thu, 10 Jan 2019 09:59:14 +0000
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     Lepton Wu <ytht.net@...il.com>
Cc:     netdev@...r.kernel.org, decui@...rosoft.com, jhansen@...are.com
Subject: Re: [PATCH] Fix ERROR:do not initialise statics to 0 in af_vsock.c

On Wed, Jan 09, 2019 at 03:45:41PM -0800, Lepton Wu wrote:
> Found by scripts/checkpatch.pl
> ---

Please include your Signed-off-by.

>  net/vmw_vsock/af_vsock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
> index 43a1dec08825..a60df252d3cc 100644
> --- a/net/vmw_vsock/af_vsock.c
> +++ b/net/vmw_vsock/af_vsock.c
> @@ -505,7 +505,7 @@ static void vsock_pending_work(struct work_struct *work)
>  static int __vsock_bind_stream(struct vsock_sock *vsk,
>  			       struct sockaddr_vm *addr)
>  {
> -	static u32 port = 0;
> +	static u32 port;

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ