netdev - Re: [PATCH net] net: clear skb->tstamp in bridge forwarding path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf5b953b-c354-4f1c-ae2f-15ea9fe19534@cumulusnetworks.com>
Date:   Thu, 10 Jan 2019 13:02:33 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Roopa Prabhu <roopa@...ulusnetworks.com>, mcroce@...hat.com,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] net: clear skb->tstamp in bridge forwarding path

On 08/01/2019 19:45, Paolo Abeni wrote:
> Matteo reported forwarding issues inside the linux bridge,
> if the enslaved interfaces use the fq qdisc.
> 
> Similar to commit 8203e2d844d3 ("net: clear skb->tstamp in
> forwarding paths"), we need to clear the tstamp field in
> the bridge forwarding path.
> 
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Reported-and-tested-by: Matteo Croce <mcroce@...hat.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  net/bridge/br_forward.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
> index 5372e2042adf..2cb8da465b98 100644
> --- a/net/bridge/br_forward.c
> +++ b/net/bridge/br_forward.c
> @@ -65,6 +65,7 @@ EXPORT_SYMBOL_GPL(br_dev_queue_push_xmit);
>  
>  int br_forward_finish(struct net *net, struct sock *sk, struct sk_buff *skb)
>  {
> +	skb->tstamp = 0;
>  	return NF_HOOK(NFPROTO_BRIDGE, NF_BR_POST_ROUTING,
>  		       net, sk, skb, NULL, skb->dev,
>  		       br_dev_queue_push_xmit);
> 

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>