netdev - RE: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in ixgbe_reset_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D3510C4@ORSMSX104.amr.corp.intel.com>
Date:   Fri, 11 Jan 2019 18:46:22 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in
 ixgbe_reset_hw_82599()

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...osl.org] On
> Behalf Of Jiri Kosina
> Sent: Wednesday, January 2, 2019 11:21 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
> Cc: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; linux-
> kernel@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in
> ixgbe_reset_hw_82599()
> 
> From: Jiri Kosina <jkosina@...e.cz>
> 
> ixgbe_reset_hw_82599() resets the value of hw->mac.num_rar_entries to
> pre-defined value of 128. Let's get rid of that hardcoded literal, and use
> IXGBE_82599_RAR_ENTRIES instead, the same way the normal initialization
> path does.
> 
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>