netdev - RE: hns: question regarding ae_node device node refcounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93C0F34A1@FRAEML521-MBS.china.huawei.com>
Date:   Fri, 11 Jan 2019 19:43:30 +0000
From:   Salil Mehta <salil.mehta@...wei.com>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@...wei.com>,
        "lipeng (Y)" <lipeng321@...wei.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>
Subject: RE: hns: question regarding ae_node device node refcounting

Hi Alexey,

> From: Alexey Khoroshilov [mailto:khoroshilov@...ras.ru]
> Sent: Saturday, December 22, 2018 9:55 PM
> To: Zhuangyuzeng (Yisen) <yisen.zhuang@...wei.com>; Salil Mehta
> <salil.mehta@...wei.com>; lipeng (Y) <lipeng321@...wei.com>
> Cc: Alexey Khoroshilov <khoroshilov@...ras.ru>; David S. Miller
> <davem@...emloft.net>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; ldv-project@...uxtesting.org
> Subject: net: hns: question regarding ae_node device node refcounting
> 
> Hello,
> 
> hns_nic_dev_probe() increments refcount of ae_node device node:
> 	ae_node = of_parse_phandle(dev->of_node, "ae-handle", 0);
> 
> But there is no of_node_put() for ae_node.
> What is the right place to decrement the ae_node refount?
> 
> Should it be placed in hns_nic_dev_probe() or in hns_nic_dev_remove()?
> Or may be it is managed by fwnode somehow?

Thanks for bringing this to notice. Yes, you are right of_node_put()
is missing. We will float a fix for this soon.

Cheers
Salil