netdev - Re: [PATCH bpf 0/3] bpf: fix bpffs/bpftool bitfield value printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3856ca3c-6547-385c-00f1-8b40a2ccb0ba@iogearbox.net>
Date:   Fri, 11 Jan 2019 11:00:24 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, netdev@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...com>, kernel-team@...com
Subject: Re: [PATCH bpf 0/3] bpf: fix bpffs/bpftool bitfield value printing

On 01/10/2019 08:14 PM, Yonghong Song wrote:
> The previous BTF kind_flag support patch set introduced a bug
> for kernel bpffs pretty printing and another bug for bpftool
> map pretty printing. If a bitfield struct member offset is
> greater than 256 bits, printed value for that struct
> member will be incorrect.
> 
> Patch #1 fixed the bug in kernel bpffs pretty printing.
> Patch #2 enhanced the test_btf test case to cover the issue
> exposed by patch #1.
> Patch #3 fixed the bug in bpftool map pretty printing.
> 
> Yonghong Song (3):
>   bpf: fix bpffs bitfield pretty print
>   tools/bpf: test btf bitfield with >=256 struct member offset
>   tools/bpf: fix bpftool map dump with bitfields
> 
>  kernel/bpf/btf.c                       | 12 +++++------
>  tools/bpf/bpftool/btf_dumper.c         | 13 ++++++------
>  tools/testing/selftests/bpf/test_btf.c | 29 +++++++++++++++++++-------
>  3 files changed, 34 insertions(+), 20 deletions(-)
> 

Applied, thanks!