netdev - Re: [PATCH net] tcp: allow MSG_ZEROCOPY transmission also in CLOSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Jan 2019 02:45:44 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Soheil Hassas Yeganeh <soheil@...gle.com>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Marek Majkowski <marek@...udflare.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Alexey Kodanev <alexey.kodanev@...cle.com>
Subject: Re: [PATCH net] tcp: allow MSG_ZEROCOPY transmission also in
 CLOSE_WAIT state



On 01/10/2019 11:45 AM, Soheil Hassas Yeganeh wrote:
> On Thu, Jan 10, 2019 at 2:40 PM Willem de Bruijn
> <willemdebruijn.kernel@...il.com> wrote:
>>
>> From: Willem de Bruijn <willemb@...gle.com>
>>
>> TCP transmission with MSG_ZEROCOPY fails if the peer closes its end of
>> the connection and so transitions this socket to CLOSE_WAIT state.
>>
>> Transmission in close wait state is acceptable. Other similar tests in
>> the stack (e.g., in FastOpen) accept both states. Relax this test, too.
>>
>> Link: https://www.mail-archive.com/netdev@vger.kernel.org/msg276886.html
>> Link: https://www.mail-archive.com/netdev@vger.kernel.org/msg227390.html
>> Fixes: f214f915e7db ("tcp: enable MSG_ZEROCOPY")
>> Reported-by: Marek Majkowski <marek@...udflare.com>
>> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
>> CC: Yuchung Cheng <ycheng@...gle.com>
>> CC: Neal Cardwell <ncardwell@...gle.com>
>> CC: Soheil Hassas Yeganeh <soheil@...gle.com>
>> CC: Alexey Kodanev <alexey.kodanev@...cle.com>
> 
> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Thank you for the fix!

Reviewed-by: Eric Dumazet <edumazet@...gle.com>