lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 11 Jan 2019 14:37:30 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Camelia Groza <camelia.groza@....com>
Cc:     f.fainelli@...il.com, hkallweit1@...il.com, davem@...emloft.net,
        oss@...error.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: guard against accessing a NULL features
 bitmap

On Fri, Jan 11, 2019 at 01:56:46PM +0200, Camelia Groza wrote:
> Since phy driver features became a link_mode bitmap, phy drivers that
> don't have a list of features configured will cause the kernel to crash
> when probed.

Hi Camelia

A NULL features is a driver bug. So i would prefer to solve this
differently.

Please make phy_driver_register() do a WARN_ON(!new_driver->features)
and return -EINVAL.

Do you know of a specific driver which as a NULL value? We should fix
that as well.

Thank
	Andrew

Powered by blists - more mailing lists