netdev - Re: [PATCH net] fou, fou6: do not assume linear skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKWNA7Rj6HoW1j15jiDrtkGzu-i+Pseb=0Ykg32mfB7OQ@mail.gmail.com>
Date:   Fri, 11 Jan 2019 06:23:49 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH net] fou, fou6: do not assume linear skbs

On Fri, Jan 11, 2019 at 6:20 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Fri, Jan 11, 2019 at 6:15 AM Stefano Brivio <sbrivio@...hat.com> wrote:
> >
> > On Fri, 11 Jan 2019 04:55:52 -0800
> > Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > > Both gue_err() and gue6_err() incorrectly assume
> > > linear skbs. Fix them to use pskb_may_pull().
> >
> > Thanks for fixing this! I stupidly didn't suspect we could get
> > non-linear skbs there. Just two things:
>
>
> > > +     if (!pskb_may_pull(skb, len + optlen)
> >                                              ^ ) missing
>
>
> Interesting, I had no compile error there :/
>
> I will send a V2

Ah, CONFIG_NET_FOU_IP_TUNNELS was not set, of course.